Skip to content

Add documentation about fuzzy word search #1729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Conversation

BeritJanssen
Copy link
Contributor

close #1712 .

Copy link
Contributor

@lukavdplas lukavdplas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I have two minor suggestions, feel free to merge after that.

@@ -47,6 +59,7 @@ Illustrating the differences when searching for different combinations of `bank`
| `bank~1` | 76241 hits (compare with just bank) |
| `"the bank is"` | 24 hits |
| `"the bank is" ~1`| 32 hits |
| `"interest balance"~5 "balance interest"~5` | 285 hits |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is almost identical to the row above it, but switches to a different example. Suggestion for clarity:

Suggested change
| `"interest balance"~5 "balance interest"~5` | 285 hits |
| `"the bank is"~5 "is the bank"~5` | 285 hits |

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to rewrite this and the above examples to asset / bank combinations, as that is what the text on top of the section states.

@@ -27,6 +27,18 @@ By default the search will combine all terms using `OR`. This means that when yo
### Be Careful with Spaces
Adding or removing a space can change the results of your query. For example search for `+- term` is different than searching for `+-term`. It might be necessary to escape a space (also by placing a `\` in front of it).

### Advanced options to search for combinations of words
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks clear! It seems to contradict line 21, though. I think that one needs to be cleared up.

@BeritJanssen BeritJanssen merged commit c7040c1 into develop Jan 16, 2025
1 check passed
@BeritJanssen BeritJanssen deleted the doc/es-syntax-manual branch January 16, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation: add more information on Elasticsearch query syntax to the manual
2 participants